Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery
ClosedPublic

Authored by aklapper on Aug 15 2024, 12:33.
Tags
None
Referenced Files
F4011729: D25779.1746626541.diff
Tue, May 6, 14:02
F3701790: D25779.1745607085.diff
Thu, Apr 24, 18:51
F3701680: D25779.1745603782.diff
Thu, Apr 24, 17:56
F3684098: D25779.1745570738.diff
Thu, Apr 24, 08:45
F3673868: D25779.1745481030.diff
Wed, Apr 23, 07:50
F3460618: D25779.1744739011.diff
Mon, Apr 14, 17:43
F3427660: D25779.1744653610.diff
Sun, Apr 13, 18:00
F3387587: D25779.1744439113.diff
Fri, Apr 11, 06:25

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38

Closes T15399

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable