Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery
ClosedPublic

Authored by aklapper on Aug 15 2024, 12:33.
Tags
None
Referenced Files
F3321436: D25779.1743353803.diff
Sat, Mar 29, 16:56
F3320874: D25779.1743338926.diff
Sat, Mar 29, 12:48
F3295898: D25779.1742963550.diff
Tue, Mar 25, 04:32
F3294542: D25779.1742937703.diff
Mon, Mar 24, 21:21
F3294239: D25779.1742931082.diff
Mon, Mar 24, 19:31
F3292654: D25779.1742898053.diff
Mon, Mar 24, 10:20
F3285558: D25779.1742804199.diff
Sun, Mar 23, 08:16
F3254885: D25779.1742488008.diff
Wed, Mar 19, 16:26

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38

Closes T15399

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Branch
php81DiffusionGitRawDiffQuery
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1529
Build 1529: arc lint + arc unit