Paths

Table of Contentst

Differential D25761

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView
ClosedPublic
Actions

Authored by aklapper on Aug 2 2024, 13:35.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15900: PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView

Commits

rP81ffe4f8b152: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/view/PhabricatorAuthAccountView.php:66]

Closes T15900

Test Plan

Try to register an account via LDAP.

Diff Detail

Repository

Branch

T15900strlenAuth

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1493
Build 1493: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 2 2024, 13:35

Owners added a reviewer: O1: Blessed Committers.Aug 2 2024, 13:35

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 2 2024, 13:35

aklapper requested review of this revision.Aug 2 2024, 13:35

Harbormaster completed remote builds in B1493: Diff 2319.Aug 2 2024, 13:35

Giving this:

https://we.phorge.it/diffusion/symbol/getAccountURI/?lang=php&repositories=PHID-REPO-u65xr6am6s7ofdkhorfk%2CPHID-REPO-wqq2xnvfxdwfaum32kbk&jump=true&path=src%2Fapplications%2Fauth%2Fview%2FPhabricatorAuthAccountView.php&char=30

And this:

https://we.phorge.it/source/phorge/browse/master/src/applications/auth/adapter/PhutilAuthAdapter.php;a110aa471e98b96c66d8f4d2e0394b97a9ea3cb8$120

It seems always a string 👍

This revision is now accepted and ready to land.Aug 2 2024, 14:18

Closed by commit rP81ffe4f8b152: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView. · Explain WhyAug 2 2024, 19:27

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP81ffe4f8b152: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

view/

PhabricatorAuthAccountView.php

2 lines

3%

Loading...

O1: Blessed Committers

Diff 2319

src/applications/auth/view/PhabricatorAuthAccountView.php

Loading...