Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView
ClosedPublic

Authored by aklapper on Aug 2 2024, 13:35.
Tags
None
Referenced Files
F2951832: D25761.1738942870.diff
Thu, Feb 6, 15:41
F2932472: D25761.1737736444.diff
Thu, Jan 23, 16:34
F2895139: D25761.1737233962.diff
Fri, Jan 17, 20:59
F2874999: D25761.1736968283.diff
Tue, Jan 14, 19:11
F2874998: D25761.1736968283.diff
Tue, Jan 14, 19:11
F2874851: D25761.1736964701.diff
Tue, Jan 14, 18:11
F2874765: D25761.1736962359.diff
Tue, Jan 14, 17:32
F2871092: D25761.1736838079.diff
Mon, Jan 13, 07:01

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/view/PhabricatorAuthAccountView.php:66]

Closes T15900

Test Plan

Try to register an account via LDAP.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable