Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView
ClosedPublic

Authored by aklapper on Aug 2 2024, 13:35.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/view/PhabricatorAuthAccountView.php:66]

Closes T15900

Test Plan

Try to register an account via LDAP.

Diff Detail

Repository
rP Phorge
Branch
T15900strlenAuth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1493
Build 1493: arc lint + arc unit