Page MenuHomePhorge

Log Herald rules with invalid actions via phlog()
ClosedPublic

Authored by aklapper on Jul 22 2024, 11:39.

Details

Summary

When Herald rules fail unexpectedly due to relying on a (now) invalid action, allow Phorge administrators to get aware by creating an entry in the error log via phlog() instead of crossing fingers that someone may from time to time get the idea to open and read Herald transcripts.

Refs T15887

Test Plan

See steps in T15887; check error log.

Diff Detail

Repository
rP Phorge
Branch
heraldRuleInvalidAction
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1447
Build 1447: arc lint + arc unit

Event Timeline

avivey subscribed.

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

This revision is now accepted and ready to land.Aug 2 2024, 07:05

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Yeah, good point. If you have thoughts how to create more visibility for Herald errors which does not require admins to look into logs, please file a ticket referring to https://we.phorge.it/maniphest/?ids=15887,15885,15869#R. Thanks for the review!