Phorge requires PHP 5.5, thus remove a version check for PHP 5.0.
Compare the same code in https://github.com/PHPMailer/PHPMailer/blob/master/src/POP3.php#L282-L283
Details
Details
- Reviewers
speck - Group Reviewers
O1: Blessed Committers - Commits
- rPa6499aee0ef4: PHPMailer: Remove a check for PHP 5.0
Carefully read the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phpMailerPhp5Check (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 1285 Build 1285: arc lint + arc unit
Event Timeline
| externals/phpmailer/class.pop3.php | ||
|---|---|---|
| 398 | In general it's probably nice to also remove this ?> so to avoid to print a newline by mistake. If it happens in a file, it's super-tricky to troubleshoot, and it breaks HTTP headers for "early output" during the class load | |
| externals/phpmailer/class.pop3.php | ||
|---|---|---|
| 398 | IMHO ideally commits are atomic and solve one thing. If you want all ?> last lines across files removed, could you please file a dedicated task so we can have a dedicated commit? Thanks! | |