Page MenuHomePhorge

PHPMailer: Remove a check for PHP 5.0
ClosedPublic

Authored by aklapper on May 17 2024, 14:18.

Details

Summary

Phorge requires PHP 5.5, thus remove a version check for PHP 5.0.
Compare the same code in https://github.com/PHPMailer/PHPMailer/blob/master/src/POP3.php#L282-L283

Test Plan

Carefully read the code.

Diff Detail

Repository
rP Phorge
Branch
phpMailerPhp5Check (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1284
Build 1284: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 17 2024, 17:57
externals/phpmailer/class.pop3.php
398

In general it's probably nice to also remove this ?> so to avoid to print a newline by mistake. If it happens in a file, it's super-tricky to troubleshoot, and it breaks HTTP headers for "early output" during the class load

externals/phpmailer/class.pop3.php
398

IMHO ideally commits are atomic and solve one thing. If you want all ?> last lines across files removed, could you please file a dedicated task so we can have a dedicated commit? Thanks!