PhabricatorDashboardPortalProfileMenuEngine calls $this->newEmptyValue() but neither PhabricatorDashboardPortalProfileMenuEngine nor its parent PhabricatorProfileMenuEngine define a newEmptyValue() method.
Thus use existing newNoContentView() in parent PhabricatorProfileMenuEngine (which according to its string output is supposed to cover this case).
Details
Details
- Reviewers
speck - Group Reviewers
O1: Blessed Committers - Commits
- rPf8b8d8876d56: Fix call to non-existing newEmptyValue() in…
Go to a Portal with no content. Before applying the patch, Phorge shows the message defined in the parent class PhabricatorProfileMenuEngine: No Content; No visible menu items can render content.
After applying this change, it correctly shows the message defined in PhabricatorDashboardPortalProfileMenuEngine: No Portal Content; None of the visible menu items in this portal can render any content.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- NEdashboardProfileMenuEmpty (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1269 Build 1269: arc lint + arc unit
Event Timeline
| src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php | ||
|---|---|---|
| 40 | Does this line need to use the same no content view function? | |
| src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php | ||
|---|---|---|
| 40 | No, this is a different case (portal with no objects, instead of portal with objects you cannot access). Parent class PhabricatorProfileMenuEngine defines final protected function newEmptyView($title, $message). | |