Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine
ClosedPublic
Actions

Authored by aklapper on May 16 2024, 11:16.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Commits

rPf8b8d8876d56: Fix call to non-existing newEmptyValue() in…

Summary

PhabricatorDashboardPortalProfileMenuEngine calls $this->newEmptyValue() but neither PhabricatorDashboardPortalProfileMenuEngine nor its parent PhabricatorProfileMenuEngine define a newEmptyValue() method.
Thus use existing newNoContentView() in parent PhabricatorProfileMenuEngine (which according to its string output is supposed to cover this case).

Test Plan

Go to a Portal with no content. Before applying the patch, Phorge shows the message defined in the parent class PhabricatorProfileMenuEngine: No Content; No visible menu items can render content.
After applying this change, it correctly shows the message defined in PhabricatorDashboardPortalProfileMenuEngine: No Portal Content; None of the visible menu items in this portal can render any content.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 16 2024, 11:16

Owners added a reviewer: O1: Blessed Committers.May 16 2024, 11:16

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 16 2024, 11:16

aklapper requested review of this revision.May 16 2024, 11:16

Harbormaster completed remote builds in B1269: Diff 1999.May 16 2024, 11:16

aklapper edited the test plan for this revision. (Show Details)Jun 21 2024, 14:52

speck subscribed.Jun 22 2024, 03:01

speck added inline comments.

src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
40	Does this line need to use the same no content view function?

aklapper marked an inline comment as done.Jun 23 2024, 14:26

aklapper added inline comments.

src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
40	No, this is a different case (portal with no objects, instead of portal with objects you cannot access). Parent class `PhabricatorProfileMenuEngine` defines `final protected function newEmptyView($title, $message)`.