Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php
ClosedPublic

Authored by aklapper on May 1 2024, 15:40.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15807

Test Plan

Unknown. Given that $value is later used to construct a phutil_tag I assume that it should be a string and not a scalar.

Diff Detail

Repository
rP Phorge
Branch
T15807 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1210
Build 1210: arc lint + arc unit