Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php
ClosedPublic

Authored by aklapper on May 1 2024, 15:40.
Tags
None
Referenced Files
F3331226: D25610.1743503652.diff
Mon, Mar 31, 10:34
F3328865: D25610.1743463719.diff
Sun, Mar 30, 23:28
F3327340: D25610.1743436955.diff
Sun, Mar 30, 16:02
F3309850: D25610.1743188969.diff
Thu, Mar 27, 19:09
F3305876: D25610.1743121675.diff
Thu, Mar 27, 00:27
F3249470: D25610.1742286247.diff
Mon, Mar 17, 08:24
F3220634: D25610.1741811340.diff
Tue, Mar 11, 20:29
F3220247: D25610.1741800662.diff
Tue, Mar 11, 17:31

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15807

Test Plan

Unknown. Given that $value is later used to construct a phutil_tag I assume that it should be a string and not a scalar.

Diff Detail

Repository
rP Phorge
Branch
T15807 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1210
Build 1210: arc lint + arc unit