Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune
ClosedPublic

Authored by aklapper on Jan 26 2024, 18:13.
Tags
None
Referenced Files
F3553430: D25528.1744933360.diff
Wed, Apr 16, 23:42
F3552857: D25528.1744909777.diff
Wed, Apr 16, 17:09
F3530197: D25528.1744871689.diff
Wed, Apr 16, 06:34
F3483818: D25528.1744773095.diff
Tue, Apr 15, 03:11
F3453422: D25528.1744722234.diff
Mon, Apr 14, 13:03
F3448892: D25528.1744708940.diff
Mon, Apr 14, 09:22
F3395394: D25528.1744516533.diff
Sat, Apr 12, 03:55
F3392263: D25528.1744485038.diff
Fri, Apr 11, 19:10

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]

Closes T15725

Test Plan

See steps in T15725

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable