Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune
ClosedPublic

Authored by aklapper on Jan 26 2024, 18:13.
Tags
None
Referenced Files
F3176172: D25528.1741297891.diff
Wed, Mar 5, 21:51
F3044663: D25528.1740965244.diff
Sun, Mar 2, 01:27
F3001441: D25528.1740442130.diff
Mon, Feb 24, 00:08
F3001440: D25528.1740442130.diff
Mon, Feb 24, 00:08
F2987197: D25528.1740110750.diff
Thu, Feb 20, 04:05
F2982281: D25528.1739948796.diff
Tue, Feb 18, 07:06
F2962711: D25528.1739181730.diff
Sun, Feb 9, 10:02
F2962710: D25528.1739181727.diff
Sun, Feb 9, 10:02

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]

Closes T15725

Test Plan

See steps in T15725

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable