Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune
ClosedPublic

Authored by aklapper on Jan 26 2024, 18:13.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 01:11
Unknown Object (File)
Sat, May 4, 14:22
Unknown Object (File)
Sat, May 4, 14:21
Unknown Object (File)
Sat, May 4, 13:23
Unknown Object (File)
Sat, May 4, 12:31
Unknown Object (File)
Sun, Apr 28, 12:42
Unknown Object (File)
Sat, Apr 27, 03:30
Unknown Object (File)
Sat, Apr 27, 03:30

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]

Closes T15725

Test Plan

See steps in T15725

Diff Detail

Repository
rP Phorge
Branch
phortuneMerchantPhp81 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1046
Build 1046: arc lint + arc unit