Paths

Table of Contentst

Differential D25494

Fix PHP 8.1 exception creating task when custom select field configured
ClosedPublic
Actions

Authored by aklapper on Dec 10 2023, 00:00.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured

Commits

rP8e09dbfee343: Fix PHP 8.1 exception creating task when custom select field configured

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:14]

Closes T15691

Test Plan

After configuring a custom select field, try to create a task via a Maniphest form using that custom field.

Diff Detail

Repository

rP Phorge

Branch

T15691 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 980
Build 980: arc lint + arc unit

Event Timeline

aklapper created this revision.Dec 10 2023, 00:00

Owners added a reviewer: O1: Blessed Committers.Dec 10 2023, 00:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 10 2023, 00:00

aklapper requested review of this revision.Dec 10 2023, 00:00

Harbormaster completed remote builds in B980: Diff 1581.Dec 10 2023, 00:00

speck subscribed.Dec 10 2023, 01:48

speck added inline comments.

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
14	Can value be non-string like integer? Might be safer to null-check && strlen

I assumed that $this->newStringIndex($value) in the next line implies a string here but let's play safe, indeed.

Harbormaster completed remote builds in B991: Diff 1598.Dec 18 2023, 23:24

This works as long as getFieldValue() never returns an object (that has a toString, that may be empty)

But, assuming that line 76 never exploded (so, object never met), this is OK to me

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
76–78	Interesting piece

valerio.bozzolan mentioned this in Z5: Phorge (flame).Jan 8 2024, 18:17

Does anyone dare to accept the last revision? :)

Same comment about keeping strlen. Up to you if you want to switch before landing.

This revision is now accepted and ready to land.Jan 11 2024, 23:25

Use strlen() instead of empty string check

Harbormaster completed remote builds in B1013: Diff 1624.Jan 12 2024, 01:04

Closed by commit rP8e09dbfee343: Fix PHP 8.1 exception creating task when custom select field configured. · Explain WhyJan 12 2024, 07:40

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP8e09dbfee343: Fix PHP 8.1 exception creating task when custom select field configured.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldSelect.php

2 lines

O1: Blessed Committers

Diff 1581

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Fix PHP 8.1 exception creating task when custom select field configuredClosedPublicActions