Page MenuHomePhorge
Differential D25467

Align logo image and text in site header
ClosedPublic
Actions

Authored by • l2dy on Nov 12 2023, 09:41.
Tags
None
Referenced Files
F2949751: D25467.1738668313.diff
Mon, Feb 3, 11:25
F2945168: D25467.1738296021.diff
Thu, Jan 30, 04:00
F2943074: D25467.1738160564.diff
Tue, Jan 28, 14:22
F2929326: D25467.1737654653.diff
Wed, Jan 22, 17:50
F2929325: D25467.1737654652.diff
Wed, Jan 22, 17:50
F2928929: D25467.1737653351.diff
Wed, Jan 22, 17:29
F2927010: D25467.1737645740.diff
Wed, Jan 22, 15:22
F2926953: D25467.1737644067.diff
Wed, Jan 22, 14:54
View All 9 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15666: Align logo image and text in site header
Commits
rPaa8af1d79e8b: Align logo image and text in site header
Summary

Ref T15666. Center wordmark vertically to align with logo in site header.

Test Plan
  • Check alignment visually.
  • With browser DevTools, verify that wordmark is 44px tall.

Diff Detail

Repository
rP Phorge
Branch
feat/header-align
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 913
Build 913: arc lint + arc unit

Event Timeline

• l2dy created this revision.Nov 12 2023, 09:41
Owners added a reviewer: O1: Blessed Committers.Nov 12 2023, 09:41
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 12 2023, 09:41
• l2dy requested review of this revision.Nov 12 2023, 09:41
Harbormaster completed remote builds in B913: Diff 1483.Nov 12 2023, 09:41
valerio.bozzolan accepted this revision.Nov 13 2023, 07:56

Uh! Nice!

Interestingly this CSS change only has effects on Chromium 119 and it does not change anything in my Mozilla Firefox 118. Can you give a quick look?

(Whatever you reply I think somebody will accept - so - accepting, but please share this small feedback - thanks!)

This revision is now accepted and ready to land.Nov 13 2023, 07:56
• l2dy added a comment.Nov 13 2023, 09:46
In D25467#13453, @valerio.bozzolan wrote:

Uh! Nice!

Interestingly this CSS change only has effects on Chromium 119 and it does not change anything in my Mozilla Firefox 118. Can you give a quick look?

I have verified the fix on Firefox. Are you sure phabricator/c0bdb5b4/core.pkg.css is loaded?

Closed by commit rPaa8af1d79e8b: Align logo image and text in site header. · Explain WhyNov 13 2023, 09:56
This revision was automatically updated to reflect the committed changes.
• l2dy added a commit: rPaa8af1d79e8b: Align logo image and text in site header.
valerio.bozzolan added a comment.Nov 13 2023, 10:07
In D25467#13458, @l2dy wrote:

I have verified the fix on Firefox. Are you sure phabricator/c0bdb5b4/core.pkg.css is loaded?

I think yes but don't worry I trust your check. It was really ~1 pixel difference in my Chromium on my 1920x1080

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
application/
base/
3 linesO1: Blessed Committers

Diff 1483

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0