Page MenuHomePhorge

Adjust message in timezone conflict form
ClosedPublic

Authored by waldyrious on Nov 7 2023, 15:59.
Tags
None
Referenced Files
F2936338: D25458.1737913334.diff
Sat, Jan 25, 17:42
F2929307: D25458.1737654644.diff
Wed, Jan 22, 17:50
F2929306: D25458.1737654644.diff
Wed, Jan 22, 17:50
F2929305: D25458.1737654643.diff
Wed, Jan 22, 17:50
F2928523: D25458.1737650515.diff
Wed, Jan 22, 16:41
F2896485: D25458.1737241879.diff
Fri, Jan 17, 23:11
Tokens
"Love" token, awarded by aklapper.

Details

Summary

This applies a suggestion initially proposed in
https://we.phorge.it/D25420#12264

Test Plan
  • Change your browser/system timezone to differ from your Phorge profile timezone
  • Click the notice that Phorge shows at the bottom left about the timezone mismatch
  • Confirm that the form text has been changed as per the diff in this revision

Diff Detail

Repository
rP Phorge
Branch
timezone-conflict-message-tweak
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 897
Build 897: arc lint + arc unit

Event Timeline

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
118

Maybe?

Thanks

Tested, it works, thanks :) Just feel free to follow the suggestion

This revision is now accepted and ready to land.Nov 8 2023, 08:36
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
118

Yeah, sure. I'll make the change.

  • Adjust message per code review suggestion