Paths

Table of Contentst

only update cache file if something changed
ClosedPublic
Actions

Authored by avivey on Oct 5 2023, 12:27.

Details

Reviewers

fgaz
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC98d16d27cf3e: only update cache file if something changed

Summary

See Q77. When installing in a read-only location, updating the file is both redundant (nothing changed) and fails.

Make sure to only save the updated file if anything changed.

Test Plan

Run arc lint somewhere, make .phutil_module_cache and src/ read-only, run arc lint again - it should avoid crashing.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Oct 5 2023, 12:27

Owners added a reviewer: O1: Blessed Committers.Oct 5 2023, 12:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 5 2023, 12:27

avivey requested review of this revision.Oct 5 2023, 12:27

Harbormaster completed remote builds in B859: Diff 1408.Oct 5 2023, 12:27

avivey mentioned this in Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).Oct 5 2023, 12:27

looks good

Tested before/after, thanks :)

Just to clarify the test plan, is the file .phutil_module_cache supposed to be in /src?

This revision is now accepted and ready to land.Oct 11 2023, 05:28

Yeah, the first run of arc lint creates the file, and subsequent runs do not update it.

Closed by commit rARC98d16d27cf3e: only update cache file if something changed. · Explain WhyOct 12 2023, 16:22

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rARC98d16d27cf3e: only update cache file if something changed.

fgaz mentioned this in Q77: Arcanist writes cache files to its source directory, and this prevents packaging.Oct 13 2023, 06:39

Revision Contents
Changeset List

Path

Size

Packages

src/

moduleutils/

PhutilLibraryMapBuilder.php

10 lines

O1: Blessed Committers

Diff 1415

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

only update cache file if something changedClosedPublicActions