Page MenuHomePhorge

Update path in startup error
ClosedPublic

Authored by fgaz on Oct 3 2023, 12:51.
Tags
None
Referenced Files
F2941069: D25445.1738087718.diff
Mon, Jan 27, 18:08
F2933374: D25445.1737764926.diff
Fri, Jan 24, 00:28
F2889452: D25445.1737202230.diff
Fri, Jan 17, 12:10
F2880051: D25445.1737067786.diff
Wed, Jan 15, 22:49
F2878703: D25445.1737024447.diff
Wed, Jan 15, 10:47
F2878702: D25445.1737024447.diff
Wed, Jan 15, 10:47
F2877715: D25445.1737006111.diff
Wed, Jan 15, 05:41
F2877704: D25445.1737005975.diff
Wed, Jan 15, 05:39

Details

Summary

The error mentioned a "phabricator" directory, but according to the docs it has been migrated to "phorge".

Test Plan

Move the "arcanist" directory somewhere else, run something from phorge/bin/.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 858
Build 858: arc lint + arc unit

Event Timeline

fgaz requested review of this revision.Oct 3 2023, 12:51

Thanks!

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Let's wait for more eyes on this :)

I accept but please wait at least one day before landing :) Thanks for your code contribution!

This revision is now accepted and ready to land.Oct 3 2023, 12:55
This revision was automatically updated to reflect the committed changes.