Paths

Table of Contentst

Update path in startup error
ClosedPublic
Actions

Authored by fgaz on Oct 3 2023, 12:51.

Tags

None

Referenced Files

	F3053278: D25445.1740988327.diff
	Sun, Mar 2, 07:52

	F2990016: D25445.1740168331.diff
	Thu, Feb 20, 20:05

	F2990015: D25445.1740168331.diff
	Thu, Feb 20, 20:05

	F2989939: D25445.1740167814.diff
	Thu, Feb 20, 19:56

	F2982369: D25445.1739954513.diff
	Tue, Feb 18, 08:41

	F2963412: D25445.1739204360.diff
	Sun, Feb 9, 16:19

	F2961362: D25445.1739162657.diff
	Sun, Feb 9, 04:44

	F2961360: D25445.1739162650.diff
	Sun, Feb 9, 04:44

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP71b273a62281: Update path in startup error

Summary

The error mentioned a "phabricator" directory, but according to the docs it has been migrated to "phorge".

Test Plan

Move the "arcanist" directory somewhere else, run something from phorge/bin/.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fgaz created this revision.Oct 3 2023, 12:51

Owners added a reviewer: O1: Blessed Committers.Oct 3 2023, 12:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 3 2023, 12:51

fgaz requested review of this revision.Oct 3 2023, 12:51

Harbormaster completed remote builds in B858: Diff 1406.Oct 3 2023, 12:51

Thanks!

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Let's wait for more eyes on this :)

I accept but please wait at least one day before landing :) Thanks for your code contribution!

This revision is now accepted and ready to land.Oct 3 2023, 12:55

Closed by commit rP71b273a62281: Update path in startup error. · Explain WhyOct 5 2023, 08:36

This revision was automatically updated to reflect the committed changes.

fgaz added a commit: rP71b273a62281: Update path in startup error.

Revision Contents
Changeset List

Path

Size

Packages

support/

startup/

PhabricatorStartup.php

2 lines

O1: Blessed Committers

Diff 1407

View Options

support/startup/PhabricatorStartup.php

Update path in startup errorClosedPublicActions