Page MenuHomePhorge

Update ArcanistComposerLinter.php to check content-hash instead of hash
ClosedPublic

Authored by Sten on Sep 27 2023, 09:11.
Tags
None
Referenced Files
F2998642: D25442.1740414732.diff
Sun, Feb 23, 16:32
F2998634: D25442.1740414686.diff
Sun, Feb 23, 16:31
F2996924: D25442.1740388414.diff
Sun, Feb 23, 09:13
F2990012: D25442.1740168327.diff
Thu, Feb 20, 20:05
F2990011: D25442.1740168326.diff
Thu, Feb 20, 20:05
F2990010: D25442.1740168324.diff
Thu, Feb 20, 20:05
F2990009: D25442.1740168324.diff
Thu, Feb 20, 20:05
F2989937: D25442.1740167812.diff
Thu, Feb 20, 19:56

Details

Summary

The 'hash' key in composer.json files was removed by composer version 1.3.0 in December 2016, in favour of the 'content-hash' key.

Update the code to validate the content-hash instead.

Fixes T15647

Test Plan
  • Update a composer.json file, without running 'composer update'
  • Run 'arc lint' and confirm it warns you that the composer.lock file is out of date
  • Run 'composer update'
  • Run 'arc lint' and confirm it returns OKAY

Diff Detail

Repository
rARC Arcanist
Branch
composerlinthash (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 853
Build 853: arc lint + arc unit

Event Timeline

Sten requested review of this revision.Sep 27 2023, 09:11
Sten planned changes to this revision.Sep 27 2023, 09:12

Lint & fix xml unit test

This revision is now accepted and ready to land.Sep 27 2023, 20:21