Page MenuHomePhorge

Update ArcanistComposerLinter.php to check content-hash instead of hash
ClosedPublic

Authored by Sten on Sep 27 2023, 09:11.
Tags
None
Referenced Files
F3341923: D25442.1743659131.diff
Wed, Apr 2, 05:45
F3341574: D25442.1743654496.diff
Wed, Apr 2, 04:28
F3335753: D25442.1743567147.diff
Tue, Apr 1, 04:12
F3334726: D25442.1743553388.diff
Tue, Apr 1, 00:23
F3319654: D25442.1743312255.diff
Sat, Mar 29, 05:24
F3315553: D25442.1743242110.diff
Fri, Mar 28, 09:55
F3314023: D25442.1743225086.diff
Fri, Mar 28, 05:11
F3310164: D25442.1743190783.diff
Thu, Mar 27, 19:39

Details

Summary

The 'hash' key in composer.json files was removed by composer version 1.3.0 in December 2016, in favour of the 'content-hash' key.

Update the code to validate the content-hash instead.

Fixes T15647

Test Plan
  • Update a composer.json file, without running 'composer update'
  • Run 'arc lint' and confirm it warns you that the composer.lock file is out of date
  • Run 'composer update'
  • Run 'arc lint' and confirm it returns OKAY

Diff Detail

Repository
rARC Arcanist
Branch
composerlinthash (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 853
Build 853: arc lint + arc unit

Event Timeline

Sten requested review of this revision.Sep 27 2023, 09:11
Sten planned changes to this revision.Sep 27 2023, 09:12

Lint & fix xml unit test

This revision is now accepted and ready to land.Sep 27 2023, 20:21