The 'hash' key in composer.json files was removed by composer version 1.3.0 in December 2016, in favour of the 'content-hash' key.
Update the code to validate the content-hash instead.
Fixes T15647
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash"
- Commits
- rARCba42b63704b2: Update ArcanistComposerLinter.php to check content-hash instead of hash
- Update a composer.json file, without running 'composer update'
- Run 'arc lint' and confirm it warns you that the composer.lock file is out of date
- Run 'composer update'
- Run 'arc lint' and confirm it returns OKAY
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- composerlinthash (branched from master)
- Lint
Lint Warnings Severity Location Code Message Warning src/lint/linter/ArcanistComposerLinter.php:90 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:92 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:94 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:108 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:110 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:111 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:114 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:117 XHP9 Naming Conventions Warning src/lint/linter/ArcanistComposerLinter.php:119 XHP9 Naming Conventions - Unit
Test Failures - Build Status
Buildable 851 Build 851: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 268 ms | ArcanistPhpcsLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "basics.lint-test".
MISSING MESSAGES
Message with severity "error" at "2:1"
| |
| 17 ms | ArcanistXMLLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "languages-6.lint-test".
MISSING MESSAGES
Message with severity "error" at "3:16" (XML76)
| |
| 10 ms | ArcanistChmodLinterTestCase::testLinter 5 assertion(s) passed. | |
| 0 ms | ArcanistClosureLinterTestCase::testVersion 1 assertion(s) passed. | |
| 0 ms | ArcanistCpplintLinterTestCase::testVersion 1 assertion(s) passed. | |
| View Full Test Results (2 Failed · 22 Passed · 29 Skipped) |