Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan
ClosedPublic

Authored by aklapper on Aug 6 2023, 20:37.
Tags
None
Referenced Files
F3305760: D25376.1743119413.diff
Wed, Mar 26, 23:50
F3299687: D25376.1743026323.diff
Tue, Mar 25, 21:58
F3298148: D25376.1742997724.diff
Tue, Mar 25, 14:02
F3296160: D25376.1742969562.diff
Tue, Mar 25, 06:12
F3294434: D25376.1742934768.diff
Mon, Mar 24, 20:32
F3293733: D25376.1742921722.diff
Mon, Mar 24, 16:55
F3225048: D25376.1742090297.diff
Sat, Mar 15, 01:58
F3220729: D25376.1741813076.diff
Tue, Mar 11, 20:57

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php:106]

Closes T15591

Test Plan

Visit /harbormaster/plan/edit/form/default/. "Create Build Plan" page renders as expected.

Diff Detail

Repository
rP Phorge
Branch
HarbormasterBuildPlan (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 730
Build 730: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.Aug 6 2023, 20:37
This revision is now accepted and ready to land.Aug 7 2023, 03:12