Page MenuHomePhorge

Workboard Columns: avoid page reload on Edit > Cancel
ClosedPublic

Authored by valerio.bozzolan on Jun 16 2023, 23:33.
Tags
None
Referenced Files
F3003316: D25302.1740462085.diff
Mon, Feb 24, 05:41
F2999850: D25302.1740433041.diff
Sun, Feb 23, 21:37
F2999473: D25302.1740426713.diff
Sun, Feb 23, 19:51
F2999469: D25302.1740426689.diff
Sun, Feb 23, 19:51
F2982551: D25302.1739963349.diff
Tue, Feb 18, 11:09
F2982518: D25302.1739962499.diff
Tue, Feb 18, 10:54
F2982493: D25302.1739960411.diff
Tue, Feb 18, 10:20
F2963323: D25302.1739203996.diff
Sun, Feb 9, 16:13

Details

Summary

The rationale for this change is that reloading a page unnecessarily wastes
resources that we can save.

This includes human resources (time) but also computational resources
as well. We probably save a fawn for every 1,000 clicks on that button.
A message to Greta Thunberg: now Phorge is with you.

This is the involved "Cancel" button, that does not reload the page anymore:

Archive and Hide Column Cancel button.png (197×864 px, 31 KB)

Closes T15471

Test Plan

Workboard > Column > Edit > Cancel:

The popup closes gracefully instead of a page refresh.

Also try opening the workflow in another tab (/project/board/1/hide/2/) > Cancel:

You turn back to your Workboard just as before.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan retitled this revision from Workboard: avoid page reload when clicking on Edit > Cancel to Workboard Columns: avoid page reload on Edit > Cancel.Jun 16 2023, 23:37

This one-line change is a present for my friend @Matthew

The test plan is just 2 clicks

But reviewing this is the price @Matthew :D (you know ihih)

Sorry, didn't see your earlier ping. Approved.

This revision is now accepted and ready to land.Jul 28 2023, 16:40