Paths

Table of Contentst

Differential D25338

Attach Diff to Revision: fix Repository asked twice
ClosedPublic
Actions

Authored by valerio.bozzolan on Jul 7 2023, 06:22.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15537: When creating revision from raw diff, "Repository" field is lost

Commits

rP0f07c07b3bc3: Attach Diff to Revision: fix Repository asked twice

Summary

If you manually upload a Diff (patch) from the Differential web
interface you can select the Repository.

We fix the default value of the Repository field during creation mode,
guessing the repo from the potentially already-available diff.

Closes T15537

Test Plan

Create a cute Differential Revision from web
Pick a Repository > Continue
Create a new Revision > Continue

At this point you should still have that repository instead of nothing.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25338

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 686
Build 686: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Jul 7 2023, 06:22

Owners added a reviewer: O1: Blessed Committers.Jul 7 2023, 06:22

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptJul 7 2023, 06:22

valerio.bozzolan requested review of this revision.Jul 7 2023, 06:22

Harbormaster completed remote builds in B653: Diff 1101.Jul 7 2023, 06:22

valerio.bozzolan added inline comments.Jul 7 2023, 06:25

src/applications/differential/editor/DifferentialRevisionEditEngine.php
130	Interestingly `$is_create` was already available but unused.
192	✅ Nothing changed here. See line 130.

valerio.bozzolan mentioned this in T15537: When creating revision from raw diff, "Repository" field is lost.Jul 7 2023, 06:29

avivey subscribed.Jul 17 2023, 06:16

avivey added inline comments.

src/applications/differential/editor/DifferentialRevisionEditEngine.php
244	Phid type can never be falsey if not null, this can be `if (.... && !$repository_phid && ...)`.

simplify check

Harbormaster completed remote builds in B686: Diff 1149.Jul 20 2023, 13:30

valerio.bozzolan marked an inline comment as done.Jul 20 2023, 13:30

valerio.bozzolan added inline comments.Jul 21 2023, 14:57

src/applications/differential/editor/DifferentialRevisionEditEngine.php
244	Done, thanks :)

avivey accepted this revision.Jul 21 2023, 15:44

This revision is now accepted and ready to land.Jul 21 2023, 15:44

Closed by commit rP0f07c07b3bc3: Attach Diff to Revision: fix Repository asked twice. · Explain WhyJul 22 2023, 11:55

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP0f07c07b3bc3: Attach Diff to Revision: fix Repository asked twice.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

10 lines

O1: Blessed Committers

Diff 1149

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Attach Diff to Revision: fix Repository asked twiceClosedPublicActions