Ref T15006. Change a few places that were mentioning phabricator path.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15006: Re-brand Phorge
- Commits
- rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols
Mk1 eyeball on each effected page.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- rebrand2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 664 Build 664: arc lint + arc unit
Event Timeline
| src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php | ||
|---|---|---|
| 71 | I wonder why the original author proposed to use pht() here. Maybe to allow message override (?) | |
Comment Actions
Yeah why not. asd
Premising that if we do not use pht() we are losing string-overriding support. It's weird but maybe our glorious Evan P. wanted to override "phorge/" with → "AHAHAHAHAHALOLPHORGE/". Maybe this could be re-introduced in the future adding a function like getPlatformClientNameLocalized() and getPlatformClientPathLocalized().
Comment Actions
I don't understand why the pht was there - it's a "path", why would it be translated?