Ref T15006. Change a few places that were mentioning phabricator path.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15006: Re-brand Phorge
- Commits
- rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols
Mk1 eyeball on each effected page.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- rebrand2
- Lint
Lint Errors Severity Location Code Message Error src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php:30 XHP86 Unsafe Usage of Dynamic String Warning src/applications/daemon/controller/PhabricatorDaemonLogViewController.php:174 TXT3 Line Too Long Warning src/applications/metamta/PhabricatorMetaMTAWorker.php:50 TXT3 Line Too Long - Unit
Test Failures - Build Status
Buildable 663 Build 663: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 17 ms | DiffusionServeControllerTestCase::testHandleRequest EXCEPTION (RuntimeException): preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
#0 [internal function]: PhutilErrorHandler::handleError(8192, '...', '...', 70)
#1 /home/avivey/devtools/phabricator/src/applications/repository/query/PhabricatorRepositoryQuery.php(70): preg_match('...', NULL)
| |
| 2 ms | PhabricatorAnchorTestCase::testAnchors 8 assertions passed. | |
| 605 ms | PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed. | |
| 87 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| View Full Test Results (1 Failed · 22 Passed · 1 Skipped) |
Event Timeline
| src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php | ||
|---|---|---|
| 71 | I wonder why the original author proposed to use pht() here. Maybe to allow message override (?) | |
Comment Actions
Yeah why not. asd
Premising that if we do not use pht() we are losing string-overriding support. It's weird but maybe our glorious Evan P. wanted to override "phorge/" with → "AHAHAHAHAHALOLPHORGE/". Maybe this could be re-introduced in the future adding a function like getPlatformClientNameLocalized() and getPlatformClientPathLocalized().
Comment Actions
I don't understand why the pht was there - it's a "path", why would it be translated?