Page MenuHomePhorge
Differential D25335

Fix PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error
ClosedPublic
Actions

Authored by Sten on Jul 5 2023, 13:32.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15531: PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error
Commits
rP9d512595c0e2: Fix PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error
Summary

Fix PHP 8.1 strlen(null) error in DifferentialBranchField getBranchDescription()

Fixes T15531

Test Plan

Simply viewing a diff (eg https://my.phorge.site/D1234) on a PHP 8.1 server generated the error fixed by this diff.

Also created a unit test.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten created this revision.Jul 5 2023, 13:32
Owners added a reviewer: O1: Blessed Committers.Jul 5 2023, 13:32
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 5 2023, 13:32
Sten requested review of this revision.Jul 5 2023, 13:32
Harbormaster completed remote builds in B644: Diff 1079.Jul 5 2023, 13:32
valerio.bozzolan accepted this revision as: valerio.bozzolan.Jul 5 2023, 14:15

Hard +1 if that extra newline disappears :)

src/applications/differential/customfield/DifferentialBranchField.php
42

OH NO AN EXTRA LINE

48

✅ I verified that $onto must be a string or NULL, and that any other alien type will be reported exploding violently and we like that

Sten updated this revision to Diff 1083.Jul 5 2023, 14:39

Pesky newline removed :-)

Harbormaster completed remote builds in B647: Diff 1083.Jul 5 2023, 14:39
Sten marked an inline comment as done.Jul 5 2023, 14:39
valerio.bozzolan accepted this revision.Jul 5 2023, 14:40

sgtm

This revision is now accepted and ready to land.Jul 5 2023, 14:40
Closed by commit rP9d512595c0e2: Fix PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error. · Explain WhyJul 5 2023, 15:06
This revision was automatically updated to reflect the committed changes.
Sten added a commit: rP9d512595c0e2: Fix PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error.

Revision Contents
Changeset List

Diff 1084

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialBranchField.php

Loading...
View Options

src/applications/differential/customfield/__tests__/DifferentialBranchFieldTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0