Differential D25330

Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1
ClosedPublic
Actions

Authored by Sten on Jul 4 2023, 15:25.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null)

Commits

rP5e48e16f77fd: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP…

Summary

Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1

Fixes T15523

Test Plan

https://my.phorge.site/source/myrepo/browse/master/myfile

Diff Detail

Repository

rP Phorge

Branch

DiffusionDocumentRenderingEngine (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 635
Build 635: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 4 2023, 15:25

Owners added a reviewer: O1: Blessed Committers.Jul 4 2023, 15:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 4 2023, 15:25

Sten requested review of this revision.Jul 4 2023, 15:25

Harbormaster completed remote builds in B635: Diff 1068.Jul 4 2023, 15:25

avivey accepted this revision.Jul 4 2023, 16:04

This revision is now accepted and ready to land.Jul 4 2023, 16:04

Closed by commit rP5e48e16f77fd: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP…. · Explain WhyJul 5 2023, 07:44

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP5e48e16f77fd: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

document/

DiffusionDocumentRenderingEngine.php

2 lines

O1: Blessed Committers

Diff 1068

View Options

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1ClosedPublicActions