Page MenuHomePhorge

Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
ClosedPublic

Authored by Sten on Jul 4 2023, 14:19.
Tags
None
Referenced Files
F3828214: D25328.1746050088.diff
Tue, Apr 29, 21:54
F3828181: D25328.1746047775.diff
Tue, Apr 29, 21:16
F3828133: D25328.1746044811.diff
Tue, Apr 29, 20:26
F3821490: D25328.1746021928.diff
Tue, Apr 29, 14:05
F3818422: D25328.1746017179.diff
Tue, Apr 29, 12:46
F3801278: D25328.1745945911.diff
Mon, Apr 28, 16:58
F3763638: D25328.1745839417.diff
Sun, Apr 27, 11:23
F3763637: D25328.1745839416.diff
Sun, Apr 27, 11:23

Details

Summary

DifferentialChangesetViewController loadCoverage() fails under PHP 8.1 when test coverage is provided for some but not all modified files.

Update the code to replace strlen() with phutil_nonempty_string().

Fixes T15521

Test Plan

View a diff with test coverage for some but not all files.

Diff Detail

Repository
rP Phorge
Branch
DifferentialChangesetViewController (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 632
Build 632: arc lint + arc unit