Page MenuHomePhorge

Fix "Register with Approval flow" for php 8
ClosedPublic

Authored by avivey on Jun 30 2023, 08:34.
Tags
None
Referenced Files
F3748969: D25317.1745789925.diff
Sat, Apr 26, 21:38
F3733436: D25317.1745745741.diff
Sat, Apr 26, 09:22
F3731299: D25317.1745740039.diff
Sat, Apr 26, 07:47
F3720290: D25317.1745707166.diff
Fri, Apr 25, 22:39
F3686614: D25317.1745582385.diff
Thu, Apr 24, 11:59
F3495071: D25317.1744787896.diff
Tue, Apr 15, 07:18
F3391389: D25317.1744479460.diff
Fri, Apr 11, 17:37
F3354999: D25317.1743868272.diff
Fri, Apr 4, 15:51

Details

Summary

Ref T15064.

Test Plan
  • Register as a new user
  • as admin, view user's page and approve it
  • As new user, hit "wait patiently" to go back to Home

No crashes in this flow.

Diff Detail

Repository
rP Phorge
Branch
register-80
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 612
Build 612: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Jun 30 2023, 08:34
src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
153

If I understand correctly this removes empty lines.

In your opinion, where does an empty blocklist entry come from?

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
153

Removes empty ("falsy", probably) entries.
The blocklist is made up of a bunch of different sources - possibly some of them can only be null in debug mode; I wasn't able to determine which one was null in this case.

This revision is now accepted and ready to land.Jun 30 2023, 11:33