Differential D25317

Fix "Register with Approval flow" for php 8
ClosedPublic
Actions

Authored by avivey on Jun 30 2023, 08:34.

Tags

None

Referenced Files

	F2935874: D25317.1737881081.diff
	Sat, Jan 25, 08:44

	F2934752: D25317.1737802220.diff
	Fri, Jan 24, 10:50

	F2930200: D25317.1737672086.diff
	Wed, Jan 22, 22:41

	F2905178: D25317.1737339101.diff
	Sun, Jan 19, 02:11

	F2899598: D25317.1737263013.diff
	Sat, Jan 18, 05:03

	F2871015: D25317.1736833236.diff
	Mon, Jan 13, 05:40

	F2870837: D25317.1736823020.diff
	Mon, Jan 13, 02:50

	F2862942: D25317.1736454358.diff
	Wed, Jan 8, 20:25

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4

Commits

rPd725ffaa7728: Fix "Register with Approval flow" for php 8

Summary

Test Plan

Register as a new user
as admin, view user's page and approve it
As new user, hit "wait patiently" to go back to Home

No crashes in this flow.

Diff Detail

Repository

Branch

register-80

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 612
Build 612: arc lint + arc unit

Event Timeline

avivey created this revision.Jun 30 2023, 08:34

Owners added a reviewer: O1: Blessed Committers.Jun 30 2023, 08:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 30 2023, 08:34

avivey requested review of this revision.Jun 30 2023, 08:34

Harbormaster completed remote builds in B612: Diff 1037.Jun 30 2023, 08:34

valerio.bozzolan added inline comments.Jun 30 2023, 08:37

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
153	If I understand correctly this removes empty lines. In your opinion, where does an empty blocklist entry come from?

avivey added inline comments.Jun 30 2023, 08:52

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
153	Removes empty ("falsy", probably) entries. The blocklist is made up of a bunch of different sources - possibly some of them can only be null in debug mode; I wasn't able to determine which one was null in this case.

chris accepted this revision.Jun 30 2023, 11:33

This revision is now accepted and ready to land.Jun 30 2023, 11:33

Closed by commit rPd725ffaa7728: Fix "Register with Approval flow" for php 8. · Explain WhyJul 2 2023, 15:49

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPd725ffaa7728: Fix "Register with Approval flow" for php 8.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

controller/

PhabricatorAuthNeedsApprovalController.php

2 lines

O1: Blessed Committers

engine/

PhabricatorAuthPasswordEngine.php

2 lines

O1: Blessed Committers

infrastructure/

customfield/

standard/

PhabricatorStandardCustomField.php

2 lines

O1: Blessed Committers

Diff 1037

src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php

Loading...

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...