Maniphest T16019

AphrontFormPolicyControl label vs control ID are off by one
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aklapper
	Fri, Mar 21, 12:15

Tags

Referenced Files

	F3280166: Screenshot From 2025-03-21 13-12-49.png
	Fri, Mar 21, 12:15

Subscribers

valerio.bozzolan

Description

Set up a Maniphest task creation form which exposes the "Visible To" and "Editable By" policy controls, and visit that form.
Inspect their HTML code.
See that the accessibility labels mismatch the element IDs (off by one):

Screenshot From 2025-03-21 13-12-49.png (1×1 px, 288 KB)

Revisions and Commits

rP Phorge
	D25910	rPad7560b36491 AphrontFormPolicyControl: Reuse existing control ID

Event Timeline

aklapper created this task.Fri, Mar 21, 12:15

Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptFri, Mar 21, 12:15

aklapper added a revision: D25910: AphrontFormPolicyControl: Reuse existing control ID.Fri, Mar 21, 12:20

valerio.bozzolan subscribed.Sat, Mar 22, 22:34

aklapper closed this task as Resolved by committing rPad7560b36491: AphrontFormPolicyControl: Reuse existing control ID.Sun, Mar 23, 09:12

aklapper claimed this task.

aklapper added a commit: rPad7560b36491: AphrontFormPolicyControl: Reuse existing control ID.