Removed SQL statements relating to replicas are listed here:
START SLAVE: Use START REPLICA.
STOP SLAVE: Use STOP REPLICA.
SHOW SLAVE STATUS: Use SHOW REPLICA STATUS.
SHOW SLAVE HOSTS: Use SHOW REPLICAS.
RESET SLAVE: Use RESET REPLICA.

Ok, that's a good reason.

The installation guide is generated from this file: https://we.phorge.it/source/phorge/browse/master/src/docs/user/installation_guide.diviner$80.

avivey added a task: T16107: Mysql 8 removed keywords, making config page to fail.Thu, Jun 12, 15:20

Update docs

Harbormaster completed remote builds in B2094: Diff 3214.Thu, Jun 12, 15:20

In D26081#28663, @avivey wrote:

Ok, that's a good reason.

The installation guide is generated from this file: https://we.phorge.it/source/phorge/browse/master/src/docs/user/installation_guide.diviner$80.

Thanks for the info! I updated the docs.

Great, thanks!

You can land this now (and add to Next Up), but maybe wait for more eyeballs.

This revision is now accepted and ready to land.Thu, Jun 12, 15:39

MariaDB added support for SHOW REPLICA STATUS in MariaDB 10.5.1, which was released February 14, 2020. This means compatibility between MySQL and MariaDB diverges with this change, as MySQL 8 was released on April 19, 2018. This might be useful to note as well.

I can't find information about the deprecation for MariaDB, though. It seems that isn't happening yet.

Per the last comment, I'd say the installation guide should explicitly say The required version is MySQL 8.0 or newer, or MariaDB 10.5.1 or newer then?

In D26081#28681, @aklapper wrote:

Per the last comment, I'd say the installation guide should explicitly say The required version is MySQL 8.0 or newer, or MariaDB 10.5.1 or newer then?

It has been a long time since MySQL and MariaDB diverged and stopped guaranteeing compatability.
Does Phorge aim both databases or just MySQL then MariaDB as a possibility?

Good question! We've run Phorge on MariaDB without problems so far and I can imagine others out there to do the same. Thus it feels like it cannot hurt to communicate what we know anyway...

I'll open a new differential for MariaDB as the Installation Guide doesn't mention it clearly.

@avivey I don't have permission to land and edit the Next Up page. Could you do that for me?

You should have permission to land - try again?
I'll update the next-up, I'm not sure why it has different permissions then the rest of the things.

minsoochoo closed this revision.Fri, Jun 13, 13:14

In D26081#28686, @avivey wrote:

You should have permission to land - try again?
I'll update the next-up, I'm not sure why it has different permissions then the rest of the things.

Sorry I'm not familiar with Phorge and I closed the differential because I thought it would land the changes automatically.

In the add action dropdown, I don't see land revision or similar. How I do make commits?

You're supposed to run arc land in your workspace...

I'll land it now, I'm not sure what it does when it's "closed".

avivey added a commit: rPbe6a3542a92e: Replace SLAVE with REPLICA.Fri, Jun 13, 13:27

In D26081#28698, @avivey wrote:

You're supposed to run arc land in your workspace...

I'll land it now, I'm not sure what it does when it's "closed".

It landed without any problem. Thank you so much.

avivey mentioned this in Next Up.Fri, Jun 13, 13:40