Page MenuHomePhorge
Differential D25987

Add CSS class to object handle if user object is system agent
Needs ReviewPublic
Actions

Authored by aklapper on Fri, May 2, 23:53.
Tags
None
Referenced Files
F3955926: D25987.1746472480.diff
Sun, May 4, 19:14
F3954797: D25987.1746456555.diff
Sun, May 4, 14:49
F3954796: D25987.1746456550.diff
Sun, May 4, 14:49
F3953131: D25987.1746451150.diff
Sun, May 4, 13:19
F3950055: D25987.1746448334.diff
Sun, May 4, 12:32
F3950043: D25987.1746447549.diff
Sun, May 4, 12:19
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16051: Add a CSS class on comments to indicate whether the comment author is a bot
Summary

Set the base for future customization to easier differentiate between human actors and machines.

Test Plan

Inspect the CSS of a bot account handle and a user account handle in a Maniphest task. See that <a> has an additional phui-system-agent class.

Diff Detail

Repository
rP Phorge
Branch
T16051 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1924
Build 1924: arc lint + arc unit

Event Timeline

aklapper created this revision.Fri, May 2, 23:53
Owners added a reviewer: O1: Blessed Committers.Fri, May 2, 23:53
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, May 2, 23:53
aklapper requested review of this revision.Fri, May 2, 23:53
Harbormaster completed remote builds in B1922: Diff 2971.Fri, May 2, 23:53
aklapper updated this revision to Diff 2972.Fri, May 2, 23:57

Don't bool with the bool otherwise it bools

Harbormaster completed remote builds in B1923: Diff 2972.Fri, May 2, 23:57
aklapper updated this revision to Diff 2973.Sat, May 3, 00:04

always set a bool so we have an explicit value and don't just fallback to "false"

Harbormaster completed remote builds in B1924: Diff 2973.Sat, May 3, 00:04
valerio.bozzolan added a comment.Sat, May 3, 00:17

Uhm... can we sleep with the very possible possibility of having "User Bot" possibly everywhere? 🌈

valerio.bozzolan mentioned this in T16050: Make it easier for CSS customization to apply to comments by specific users/bots.Sat, May 3, 08:52
aklapper added a comment.Sat, May 3, 09:14
In D25987#26487, @valerio.bozzolan wrote:

having "User Bot" possibly everywhere? 🌈

No. Because consistency.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
people/
phid/
1 line3%
Loading...
O1: Blessed Committers
phid/
13 lines1%
Loading...
O1: Blessed Committers

Diff 2973

View Options

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0