Set the base for future customization to easier differentiate between human actors and machines.
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16051: Add a CSS class on comments to indicate whether the comment author is a bot
Inspect the CSS of a bot account handle and a user account handle in a Maniphest task. See that <a> has an additional phui-system-agent class.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T16051 (branched from master)
- Lint
Lint Errors Severity Location Code Message Error src/applications/phid/PhabricatorObjectHandle.php:28 XHP1 PHP Syntax Error! - Unit
Test Failures - Build Status
Buildable 1922 Build 1922: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 2,378 ms | PhabricatorLibraryTestCase::testLibraryMap EXCEPTION (XHPASTSyntaxErrorException): applications/phid/PhabricatorObjectHandle.php: XHPAST Parse Error: syntax error, unexpected T_STRING, expecting T_VARIABLE on line 28
#0 /var/www/html/phorge/arcanist/src/moduleutils/PhutilLibraryMapBuilder.php(63): PhutilLibraryMapBuilder->analyzeLibrary()
#1 /var/www/html/phorge/arcanist/src/__tests__/PhutilLibraryTestCase.php(29): PhutilLibraryMapBuilder->buildMap()
| |
| 604 ms | PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed. | |
| 1,159 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 625 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 515 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| View Full Test Results (1 Failed · 6 Passed) |
Event Timeline
Comment Actions
Uhm... can we sleep with the very possible possibility of having "User Bot" possibly everywhere? 🌈