Page MenuHomePhorge
Differential D25860

Fix typos etc.
ClosedPublic
Actions

Authored by pppery on Sun, Dec 29, 02:59.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15980: Handle typos from Q161
Commits
rPed6644f31757: Fix typos etc.
Summary

Fixes T15980

Test Plan

Read the code

Diff Detail

Repository
rP Phorge
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1669
Build 1669: arc lint + arc unit

Event Timeline

pppery created this revision.Sun, Dec 29, 02:59
Owners added a reviewer: O1: Blessed Committers.Sun, Dec 29, 02:59
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Dec 29, 02:59
pppery requested review of this revision.Sun, Dec 29, 02:59
Harbormaster completed remote builds in B1669: Diff 2598.Sun, Dec 29, 02:59
avivey accepted this revision.Sun, Dec 29, 12:23
avivey subscribed.

two items re: phrasing, but otherwise LGTM.

src/applications/config/check/PhabricatorFileinfoSetupCheck.php
12–13

maybe, "Without '%s', this software may not..." ?

also, maybe replace "this software" with "this server"?

This revision is now accepted and ready to land.Sun, Dec 29, 12:23
pppery updated this revision to Diff 2599.Sun, Dec 29, 16:33

Per avivey

Harbormaster completed remote builds in B1670: Diff 2599.Sun, Dec 29, 16:33
Closed by commit rPed6644f31757: Fix typos etc.. · Explain WhySun, Dec 29, 16:36
This revision was automatically updated to reflect the committed changes.
pppery added a commit: rPed6644f31757: Fix typos etc..

Revision Contents
Changeset List

Diff 2598

View Options

src/applications/config/check/PhabricatorFileinfoSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorGDSetupCheck.php

Loading...
View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageTransaction.php

Loading...
View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0