Page MenuHomePhorge
Differential D25860

Fix typos etc.
ClosedPublic
Actions

Authored by pppery on Dec 29 2024, 02:59.
Tags
None
Referenced Files
F3772124: D25860.1745854586.diff
Sun, Apr 27, 15:36
F3601199: D25860.1745149022.diff
Sat, Apr 19, 11:37
F3576304: D25860.1745039673.diff
Fri, Apr 18, 05:14
F3531858: D25860.1744885022.diff
Wed, Apr 16, 10:17
F3498339: D25860.1744792000.diff
Tue, Apr 15, 08:26
F3497662: D25860.1744791168.diff
Tue, Apr 15, 08:12
F3420785: D25860.1744627418.diff
Sun, Apr 13, 10:43
F3388105: D25860.1744444571.diff
Fri, Apr 11, 07:56
View All 72 Files
Subscribers
avivey
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15980: Handle typos from Q161
Commits
rPed6644f31757: Fix typos etc.
Summary

Fixes T15980

Test Plan

Read the code

Diff Detail

Repository
rP Phorge
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1669
Build 1669: arc lint + arc unit

Event Timeline

pppery created this revision.Dec 29 2024, 02:59
Owners added a reviewer: O1: Blessed Committers.Dec 29 2024, 02:59
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 29 2024, 02:59
pppery requested review of this revision.Dec 29 2024, 02:59
Harbormaster completed remote builds in B1669: Diff 2598.Dec 29 2024, 02:59
avivey accepted this revision.Dec 29 2024, 12:23
avivey subscribed.

two items re: phrasing, but otherwise LGTM.

src/applications/config/check/PhabricatorFileinfoSetupCheck.php
12–13

maybe, "Without '%s', this software may not..." ?

also, maybe replace "this software" with "this server"?

This revision is now accepted and ready to land.Dec 29 2024, 12:23
pppery updated this revision to Diff 2599.Dec 29 2024, 16:33

Per avivey

Harbormaster completed remote builds in B1670: Diff 2599.Dec 29 2024, 16:33
Closed by commit rPed6644f31757: Fix typos etc.. · Explain WhyDec 29 2024, 16:36
This revision was automatically updated to reflect the committed changes.
pppery added a commit: rPed6644f31757: Fix typos etc..

Revision Contents
Changeset List

Diff 2598

View Options

src/applications/config/check/PhabricatorFileinfoSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorGDSetupCheck.php

Loading...
View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageTransaction.php

Loading...
View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0