Allow customizing default Phurl view and edit policies
AcceptedPublic
Actions

Authored by taavi on Sun, Dec 8, 10:37.

Details

Reviewers

aklapper
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15970: phurl: Allow setting default edit policy for URLs

Summary

Before	After

Closes T15970

Test Plan

Go to http://phorge.localhost/applications/view/PhabricatorPhurlApplication/ and see two additional settings "Default View Policy" and "Default Edit Policy"
Go to http://phorge.localhost/applications/view/PhabricatorPhurlApplication/ and select "Edit Policies" to see and set two additional settings
Go to http://phorge.localhost/phurl/url/edit/form/default/ and check the "Visible To" and "Editable By" fields now showing the default page
Check existing Phurls which did not have their policies changed as that's stored in the database
run arc liberate again and see that it's already updated

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1649
Build 1649: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	PhabricatorCelerityTestCase::testCelerityMaps EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 708) #1 /home/taavi/src/phorge/docker-phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(708): xdebug_start_code_coverage(3)
	0 ms	PhabricatorConduitTestCase::testConduitMethods EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 708) #1 /home/taavi/src/phorge/docker-phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(708): xdebug_start_code_coverage(3)
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 708) #1 /home/taavi/src/phorge/docker-phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(708): xdebug_start_code_coverage(3)
	0 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 708) #1 /home/taavi/src/phorge/docker-phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(708): xdebug_start_code_coverage(3)
	0 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 708) #1 /home/taavi/src/phorge/docker-phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(708): xdebug_start_code_coverage(3)
		View Full Test Results (7 Failed)

Event Timeline

taavi created this revision.Sun, Dec 8, 10:37

Owners added a reviewer: O1: Blessed Committers.Sun, Dec 8, 10:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Dec 8, 10:37

taavi requested review of this revision.Sun, Dec 8, 10:37

Harbormaster completed remote builds in B1649: Diff 2567.Sun, Dec 8, 10:37

Fix my local unit test config

Harbormaster completed remote builds in B1650: Diff 2568.Sun, Dec 8, 10:40

taavi added inline comments.Sun, Dec 8, 10:42

src/applications/phurl/application/PhabricatorPhurlApplication.php
83	Note that this is different than the previous default (which allowed the URL creator only). I didn't find a way to make the policy default include the URL author, and the author will continue to have access since the URL class uses `hasAutomaticCapability` to always grant the author view/edit access.

Uuuh! Thanks <3

What happens to already-existing URLs? Maybe nice to mention in the test plan

In D25850#22726, @valerio.bozzolan wrote:

What happens to already-existing URLs? Maybe nice to mention in the test plan

The policies for those are saved in the database, so they stay as is. Done.

valerio.bozzolan added inline comments.Tue, Dec 10, 09:22

src/applications/phurl/application/PhabricatorPhurlApplication.php
83	I tested and this constant seems to do not exist https://we.phorge.it/source/phorge/browse/master/src/applications/policy/capability/PhabricatorPolicyCapability.php Maybe CAN_ADMIN?