Paths

Table of Contentst

Differential D25830

Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
ClosedPublic
Actions

Authored by aklapper on Mon, Oct 21, 18:08.

Tags

None

Referenced Files

	F2582821: D25830.1729750917.diff
	Wed, Oct 23, 06:21

	F2579448: D25830.1729686969.diff
	Tue, Oct 22, 12:36

	F2579447: D25830.1729686865.diff
	Tue, Oct 22, 12:34

	F2579446: D25830.1729686846.diff
	Tue, Oct 22, 12:34

	F2579445: D25830.1729686845.diff
	Tue, Oct 22, 12:34

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter

Commits

rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/PhabricatorJupyterDocumentEngine.php:326]

Closes T15951

Test Plan

Diff Detail

Repository

Branch

jupyterNbformat

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1607
Build 1607: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Oct 21, 18:08

Owners added a reviewer: O1: Blessed Committers.Mon, Oct 21, 18:08

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Oct 21, 18:08

aklapper requested review of this revision.Mon, Oct 21, 18:08

Harbormaster completed remote builds in B1607: Diff 2498.Mon, Oct 21, 18:08

The function name including a negative, “nonempty”, throws me off…

This revision is now accepted and ready to land.Tue, Oct 22, 01:04

Closed by commit rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter. · Explain WhyTue, Oct 22, 08:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

files/

document/

PhabricatorJupyterDocumentEngine.php

2 lines

0%

Loading...

O1: Blessed Committers

Diff 2498

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...