Page MenuHomePhorge

Documentation: add article about Javelin DOM stuff
ClosedPublic

Authored by valerio.bozzolan on Mon, Sep 9, 16:04.

Details

Summary

Finally we know something about:

  • how to get an element by id ($)
  • how to find some children by a parent (scry)
  • how to find an exact child by a parent (find)
  • how to find a parent by a child (findAbove)

Closes T15870

Test Plan

You read this article and you find something interesting and
probably also accurate.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested changes to this revision.Tue, Sep 10, 11:33
aklapper subscribed.

I guess D25784 shouldn't be mashed up in here thus requesting changes.

I'd personally write a few sentences in a way more boring style as I dislike reading long texts when I just quickly want to find relevant info.

webroot/rsrc/externals/javelin/docs/javelin_intro.diviner
9–15

As you know, Phorge is the fork of Phabricator. Phabricator was designed with a particular Open Source JavaScript library called Javelin.

17–23

So, why I should master Javelin?

The Javelin APIs are un-documented, un-intuitive, and esoteric, and you may prefer X / Y / Z framework instead.

24–29

But hey: Javelin will not be abandoned anytime soon.

Give Javelin a try, so you can make Phorge even better.

40–43

Traversing the DOM using Javelin is simple... as long as
you know what a "sigil" is. In fact, Javelin is designed to avoid
finding something by CSS classes. Instead, Javelin introduced
"sigils" - that is, exactly like a CSS class but vegan (?).

This revision now requires changes to proceed.Tue, Sep 10, 11:33

(I don't get the comment about D25784) thanks for feedback

Ah! yes - undo ConpherenceViewController

If Harbormaster is fine I better be fine too, dont want no problems with them for reals

This revision is now accepted and ready to land.Tue, Sep 10, 21:51

I hope that something is better than nothing I think. Then we can move if we don't like it.

This revision was landed with ongoing or failed builds.Sat, Sep 14, 13:40
This revision was automatically updated to reflect the committed changes.