Page MenuHomePhorge

Remove an outdated PHP 5.3 check in utils
ClosedPublic

Authored by aklapper on Aug 26 2024, 12:04.
Tags
None
Referenced Files
F3308843: D25808.1743179040.diff
Thu, Mar 27, 16:24
F3299473: D25808.1743022679.diff
Tue, Mar 25, 20:57
F3294447: D25808.1742934950.diff
Mon, Mar 24, 20:35
F3289422: D25808.1742846519.diff
Sun, Mar 23, 20:01
F3283721: D25808.1742758749.diff
Sat, Mar 22, 19:39
F3281072: D25808.1742670109.diff
Fri, Mar 21, 19:01
F3254924: D25808.1742488109.diff
Wed, Mar 19, 16:28
F3223368: D25808.1741941459.diff
Thu, Mar 13, 08:37

Details

Summary

parse_ini_string() has been available since PHP 5.3.0: https://www.php.net/manual/en/function.parse-ini-string.php

INI_SCANNER_RAW was introduced in PHP 5.3.0 (and received several bug fixes on the way to PHP 5.4.10): https://www.php.net/ChangeLog-5.php

Phorge requires PHP 7.2 nowadays; before rP7d8c84a7bdc8fb43674341b97c36c9d8ae1d894a Phorge already required PHP 5.5.

Thus remove this outdated check.

Test Plan

Read the docs.

Diff Detail

Repository
rARC Arcanist
Branch
php53InitScannerRawCheck
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1568
Build 1568: arc lint + arc unit