Subversion does not allow to have local commits. So, manage this case.
Closes T15612
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15612: Missing "Authored on" commit date for Subversion commits
- Commits
- rPb02615bd5027: Subversion: fix empty "Authored on" date on commit pages
Surf a git commit: nothing changed.
Surf a svn commit: the "Authored on" date is not empty anymore.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15612
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1553 Build 1553: arc lint + arc unit
Event Timeline
Comment Actions
As usual I'm confused about the PHP magic which does not require defining the method PhabricatorRepositoryCommit::getEpoch() in its class or parent classes, but I assume you tested locally that your patch works, plus PhabricatorRepositoryCommit does have some calls already to $this->getEpoch(), so I'll accept - worst case would be the very same behavior as now.
Comment Actions
Thanks. Premising that I also don't like projects with "automagic getters" so I agree with you; here how every getter works in Phabricator/Phorge:
Note that Lisk automatically builds getters and setters for all of your object's protected properties via __call(). If you want to add custom behavior to your getters or setters, you can do so by overriding the readField() and writeField() methods.
https://we.phorge.it/book/dev/class/LiskDAO/