Page MenuHomePhorge

Fix return value of PhutilTestCase::tryTestCaseMap()
ClosedPublic

Authored by aklapper on Aug 17 2024, 22:15.
Tags
None
Referenced Files
F3605532: D25791.1745276051.diff
Sun, Apr 20, 22:54
F3604452: D25791.1745200968.diff
Sun, Apr 20, 02:02
F3553672: D25791.1744950992.diff
Thu, Apr 17, 04:36
F3553144: D25791.1744921403.diff
Wed, Apr 16, 20:23
F3475906: D25791.1744756799.diff
Mon, Apr 14, 22:39
F3395929: D25791.1744519712.diff
Sat, Apr 12, 04:48
F3387627: D25791.1744439738.diff
Fri, Apr 11, 06:35
F3383595: D25791.1744391614.diff
Thu, Apr 10, 17:13

Details

Summary

PhutilTestCase::tryTestCases() returns void. Thus PhutilTestCase::tryTestCaseMap() should behave the same way as PhutilTestCase::assertException(): return void.

Test Plan

Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable