Page MenuHomePhorge

Fix return value of PhutilTestCase::tryTestCaseMap()
ClosedPublic

Authored by aklapper on Aug 17 2024, 22:15.
Tags
None
Referenced Files
F3851337: D25791.1746118378.diff
Wed, Apr 30, 16:52
F3813984: D25791.1746007954.diff
Tue, Apr 29, 10:12
F3750200: D25791.1745806090.diff
Sun, Apr 27, 02:08
F3657689: D25791.1745453063.diff
Wed, Apr 23, 00:04
F3657378: D25791.1745443473.diff
Tue, Apr 22, 21:24
F3605532: D25791.1745276051.diff
Sun, Apr 20, 22:54
F3604452: D25791.1745200968.diff
Sun, Apr 20, 02:02
F3553672: D25791.1744950992.diff
Thu, Apr 17, 04:36

Details

Summary

PhutilTestCase::tryTestCases() returns void. Thus PhutilTestCase::tryTestCaseMap() should behave the same way as PhutilTestCase::assertException(): return void.

Test Plan

Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Diff Detail

Repository
rARC Arcanist
Branch
phutilTestCaseVoid
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1544
Build 1544: arc lint + arc unit