Page MenuHomePhorge

Fix return value of PhutilTestCase::tryTestCaseMap()
ClosedPublic

Authored by aklapper on Aug 17 2024, 22:15.

Details

Summary

PhutilTestCase::tryTestCases() returns void. Thus PhutilTestCase::tryTestCaseMap() should behave the same way as PhutilTestCase::assertException(): return void.

Test Plan

Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Diff Detail

Repository
rARC Arcanist
Branch
phutilTestCaseVoid
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1544
Build 1544: arc lint + arc unit