Closes T15848
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15848: newOAuth1Future doesn't set a User-Agent
- Commits
- rP39237c0854fe: Set base-uri as User-Agent for OAuth1 and Github authentication
Unclear.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15848
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1486 Build 1486: arc lint + arc unit
Event Timeline
Comment Actions
Maybe better to discuss a little bit in T15848: newOAuth1Future doesn't set a User-Agent since I'm curious but also confused
Moreover traditionally, the user agent is the name of the software, not the origin. So this could also deserve another comment about why we should replace the specific software name with a fixed origin. Premising that I agree that the current user agent may be re-discussed, to include more information, like, "Phorge", and the version of Phorge.
Also, in case, maybe probably nice to have a getUserAgent(__CLASS__) method in parent class PhutilAuthAdapter()
Comment Actions
Not exactly sure what the confusion is. The patch and task are clear to me and solve the issue.
Moreover traditionally, the user agent is the name of the software, not the origin. So this could also deserve another comment about why we should replace the specific software name with a fixed origin. Premising that I agree that the current user agent may be re-discussed, to include more information, like, "Phorge", and the version of Phorge.
Actually no, user agents for automated tooling often includes some sort of contact email or website or link to a page describing the bot/tool. I think this should be treated like that.
Also, in case, maybe probably nice to have a getUserAgent(__CLASS__) method in parent class PhutilAuthAdapter()
Comment Actions
OK thanks (I need some rest)
At this point the only remaining feedback is about a generalization with a "getUserAgent()" in the parent class I think