Remove call to undefined method DoorkeeperDAO::getObjectKey()
ClosedPublic
Actions

Authored by aklapper on Jul 19 2024, 11:43.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPa039c4952f6b: Remove call to undefined method DoorkeeperDAO::getObjectKey()

Summary

Remove call to undefined static method DoorKeeperDAO::getObjectKey() in the DoorkeeperExternalObject class. getObjectKey() does not exist (and never existed) in any of its parent classes (DoorkeeperDAO, PhabricatorLiskDAO, LiskDAO).

Test Plan

Run static code analysis. Grep the source code and check the git history of parent classes.

Diff Detail

Repository

rP Phorge

Branch

rmUndefDoorkeeperDaoObjectKey

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1446
Build 1446: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 19 2024, 11:43

Owners added a reviewer: O1: Blessed Committers.Jul 19 2024, 11:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 19 2024, 11:43

aklapper requested review of this revision.Jul 19 2024, 11:43

Harbormaster completed remote builds in B1440: Diff 2249.Jul 19 2024, 11:43

aklapper edited the summary of this revision. (Show Details)Jul 19 2024, 11:44

valerio.bozzolan added inline comments.Jul 19 2024, 13:14

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
62–63	At this point we can just `return $this`

aklapper added inline comments.Jul 20 2024, 09:59

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
62–63	This is a getter, not a setter, not sure I understand you :-/ Did you mean saving one line via `return $this->getRef()->getObjectKey();` maybe?