Page MenuHomePhorge

Remove call to undefined method DoorkeeperDAO::getObjectKey()
ClosedPublic

Authored by aklapper on Jul 19 2024, 11:43.
Tags
None
Referenced Files
F3212696: D25734.1741466489.diff
Fri, Mar 7, 20:41
F2991926: D25734.1740198740.diff
Fri, Feb 21, 04:32
F2991925: D25734.1740198740.diff
Fri, Feb 21, 04:32
F2991924: D25734.1740198740.diff
Fri, Feb 21, 04:32
F2990373: D25734.1740177352.diff
Thu, Feb 20, 22:35
F2981950: D25734.1739943110.diff
Tue, Feb 18, 05:31
F2917971: D25734.1737509440.diff
Jan 21 2025, 01:30
F2904841: D25734.1737334826.diff
Jan 19 2025, 01:00

Details

Summary

Remove call to undefined static method DoorKeeperDAO::getObjectKey() in the DoorkeeperExternalObject class. getObjectKey() does not exist (and never existed) in any of its parent classes (DoorkeeperDAO, PhabricatorLiskDAO, LiskDAO).

Test Plan

Run static code analysis. Grep the source code and check the git history of parent classes.

Diff Detail

Repository
rP Phorge
Branch
rmUndefDoorkeeperDaoObjectKey
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1440
Build 1440: arc lint + arc unit

Event Timeline

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
63–64

At this point we can just return $this

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
63–64

This is a getter, not a setter, not sure I understand you :-/
Did you mean saving one line via return $this->getRef()->getObjectKey(); maybe?

sgtm

Just that oneline

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
63–64

Yep

This revision is now accepted and ready to land.Jul 21 2024, 22:12

Skip assigning variable; direct return