Paths

Table of Contentst

Differential D25692

Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email
ClosedPublic
Actions

Authored by mturdus on Jun 15 2024, 12:40.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email

Commits

rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/htdocs/phorge/phorge/src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php:65]

Closes T15857

Test Plan

Send Welcome email via 'Manage' user screen and Run ./bin/phd log afterwards to validate email action

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/extensions/example/src/query/ExampleQuery.php:7	PHL1	Unknown Symbol

Unit

Test Failures

Build Status

Buildable 1346
Build 1346: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,660 ms	PhabricatorLibraryTestCase::testMethodVisibility Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:144): Class "ExampleTable" implements method "getConfiguration" with the wrong visibility. The method has visibility "public", but it is defined in parent "PhabricatorLiskDAO" with visibility "protected". A method which overrides another must always have the same visibility.
	860 ms	PhabricatorCelerityTestCase::testCelerityMaps 5 assertions passed.
	728 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	477 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	479 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
		View Full Test Results (1 Failed · 7 Passed)

Event Timeline

mturdus created this revision.Jun 15 2024, 12:40

Owners added a reviewer: O1: Blessed Committers.Jun 15 2024, 12:40

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 15 2024, 12:40

Harbormaster completed remote builds in B1346: Diff 2114.Jun 15 2024, 12:40

mturdus requested review of this revision.Jun 15 2024, 12:40

mturdus retitled this revision from Fix PHP 8.1 "strlen(null)" exception in Diviner when sending email via SMTP to Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.Jun 15 2024, 12:43

Thank you!

This revision is now accepted and ready to land.Jun 15 2024, 13:12

This revision was landed with ongoing or failed builds.Jun 15 2024, 13:14

Closed by commit rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending…. · Explain Why

This revision was automatically updated to reflect the committed changes.

mturdus added a commit: rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

metamta/

adapter/

PhabricatorMailSMTPAdapter.php

2 lines

10%

O1: Blessed Committers

Diff 2114

View Options

src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php

Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending emailClosedPublicActions