Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block
ClosedPublic
Actions

Authored by aklapper on Jun 10 2024, 23:18.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block

Commits

rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerAtomController.php:440]

Closes T15853

Test Plan

Run ./bin/diviner generate and visit a Diviner page about a class which has no PHPDoc @task block, for example access http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class&jump=1

Diff Detail

Repository

rP Phorge

Branch

divinerTaskDocStrlen (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1341
Build 1341: arc lint + arc unit

Event Timeline

aklapper created this revision.Jun 10 2024, 23:18

Owners added a reviewer: O1: Blessed Committers.Jun 10 2024, 23:18

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 10 2024, 23:18

aklapper requested review of this revision.Jun 10 2024, 23:18

Harbormaster completed remote builds in B1341: Diff 2105.Jun 10 2024, 23:18

aklapper retitled this revision from Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has single @task block to Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.Jun 11 2024, 05:56

Is it possible tasks isn’t a string in this case, where non_empty_scalar might be more of a match?

Ah I see below it assumes string. Thanks!

This revision is now accepted and ready to land.Jun 11 2024, 17:15

aklapper edited the test plan for this revision. (Show Details)Jun 11 2024, 20:50

Closed by commit rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block. · Explain WhyJun 11 2024, 20:52

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.